Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TensorRT engine to ONNX Runtime GPU documentation #657

Merged
merged 10 commits into from
Jan 2, 2023
Merged

Add TensorRT engine to ONNX Runtime GPU documentation #657

merged 10 commits into from
Jan 2, 2023

Conversation

fxmarty
Copy link
Collaborator

@fxmarty fxmarty commented Jan 2, 2023

What does this PR do?

This documentation addition clarifies the usage of the TensorRT engine. Note: #653 is needed for the code samples to work.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 2, 2023 •
edited

The documentation is not available anymore as the PR was closed or merged.

@fxmarty
Copy link
Collaborator Author

fxmarty commented Jan 2, 2023

Relevant doc: https://moon-ci-docs.huggingface.co/docs/optimum/pr_657/en/onnxruntime/usage_guides/gpu#tensorrt-engine-build-and-warmup

@fxmarty fxmarty mentioned this pull request Jan 2, 2023
Closed
4 tasks
regisss
regisss reviewed Jan 2, 2023
View reviewed changes
Copy link
Contributor

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to add doc for this @fxmarty!!
I mostly left comments for typos and wording. My main comment is about the example with the different input shapes that trigger new rebuilds of the engine.

docs/source/onnxruntime/usage_guides/gpu.mdx Outdated Show resolved Hide resolved
docs/source/onnxruntime/usage_guides/gpu.mdx Outdated Show resolved Hide resolved
docs/source/onnxruntime/usage_guides/gpu.mdx Outdated Show resolved Hide resolved
docs/source/onnxruntime/usage_guides/gpu.mdx Outdated Show resolved Hide resolved
docs/source/onnxruntime/usage_guides/gpu.mdx Outdated Show resolved Hide resolved
docs/source/onnxruntime/usage_guides/gpu.mdx Outdated Show resolved Hide resolved
docs/source/onnxruntime/usage_guides/gpu.mdx Outdated Show resolved Hide resolved
fxmarty and others added 7 commits January 2, 2023 15:49
@fxmarty @regisss
Update docs/source/onnxruntime/usage_guides/gpu.mdx
5ab425b 
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
@fxmarty @regisss
Update docs/source/onnxruntime/usage_guides/gpu.mdx
4827c51 
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
@fxmarty @regisss
Update docs/source/onnxruntime/usage_guides/gpu.mdx
e4c0dbf 
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
@fxmarty @regisss
Update docs/source/onnxruntime/usage_guides/gpu.mdx
bcc527e 
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
@fxmarty @regisss
Update docs/source/onnxruntime/usage_guides/gpu.mdx
74a8479 
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
@fxmarty @regisss
Update docs/source/onnxruntime/usage_guides/gpu.mdx
5c9b3fe 
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
@fxmarty @regisss
Update docs/source/onnxruntime/usage_guides/gpu.mdx
603a9a2 
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
@fxmarty
Copy link
Collaborator Author

fxmarty commented Jan 2, 2023

@regisss Thank you for the review, much cleaner!

regisss
regisss approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@fxmarty fxmarty merged commit 72e976b into huggingface:main Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisss regisss regisss approved these changes

@echarlaix echarlaix Awaiting requested review from echarlaix

@JingyaHuang JingyaHuang Awaiting requested review from JingyaHuang

@mht-sharma mht-sharma Awaiting requested review from mht-sharma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fxmarty @HuggingFaceDocBuilderDev @regisss