[Hotfix] Fix BOFT mixed precision #1925
Open
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminBossan
requested changes
Jul 15, 2024
| @@ -77,9 +78,6 @@ def get_fbd_cuda(): | |||
| if _FBD_CUDA is not None: | |||
| return _FBD_CUDA | |||
|
|
|||
| # This import initializes cuda context and should thus be local, see issue 1877 | |||
| from torch.utils.cpp_extension import load | |||
There was a problem hiding this comment.
Could you please undo this change? The import should be local. Maybe merging with/rebasing on the latest main is sufficient.
| boft_rotation = butterfly_oft_mat @ boft_rotation | ||
| boft_scale = boft_s * boft_scale | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authors of BOFT seemingly forgot to cast some data types in the bf16/fp16 mixed precision setting, so me and @srguo24 fixed them during our research project.
See error below (reproducible when running any model with transformers trainer in bf16)