improve readability of LoRA code #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @pacman100 |
|
The documentation is not available anymore as the PR was closed or merged. |
|
Hello, could you please resolve the conflicts? |
|
@pacman100 thanks for take a look, resolved the conflict! |
|
@pacman100 let me know if any concern, thanks! |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
martin-liu
force-pushed
the
main
branch
3 times, most recently
from
c3b88d5
to
7c8d7a3
Compare
|
@pacman100 I recreated the commit from latest main branch, now all the checks passed, can you help review the code? |
pacman100
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Thank you so much @martin-liu for your great work on refactoring the LoRA code to make it more readable and easier to maintain. Also, thank you for the multiple iterations, LGTM! 🤗
|
@pacman100 Great, thank you 🍻 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating this great library!
As I was exploring LoRA implementations and reviewing the code, I noticed that there could be some enhancements made to improve code readability.
Therefore, I created this pull request which primarily focuses on extracting certain private functions without introduce any functional changes.