Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the init method,
self.peft_config
is always a dict. It'll be something like{"default": PeftConfig Instance}
.peft/src/peft/peft_model.py
Lines 97 to 113 in f5352f0
Therefore, existing
disable_adapter
method is checking the wrong item. It should checkself.peft_config["default"]
instead ofself.peft_config
peft/src/peft/peft_model.py
Lines 366 to 381 in f5352f0