Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce device_limits and device_features inside WgpuDevice to store a subset of wgpu::Limits and wgpu::Features #202

Merged
merged 3 commits into from
May 18, 2024

Conversation

officialcjunior
Copy link
Contributor

@officialcjunior officialcjunior commented May 18, 2024

Start storing a subset of wgpu::Limits and wgpu::Features on Device, so that we can start handling dispatch limits device-specifically, for example, generate shaders depending on user-supported features.

Related #185

Copy link

Code Metrics Report
  ===============================================================================
 Language            Files        Lines         Code     Comments       Blanks
===============================================================================
 TOML                    1           74           62            2           10
-------------------------------------------------------------------------------
 Rust                   62        10399         8960          119         1320
 |- Markdown            30          270            0          210           60
 (Total)                          10669         8960          329         1380
===============================================================================
 Total                  63        10473         9022          121         1330
===============================================================================
  

@officialcjunior officialcjunior marked this pull request as ready for review May 18, 2024 14:51
@officialcjunior officialcjunior changed the title Introduce Device::WgpuDevice::device_limits to store a subset of wgpu::Limits Introduce device_limits and device_features inside WgpuDevice to store a subset of wgpu::Limits and wgpu::Features May 18, 2024
@FL33TW00D FL33TW00D merged commit bfc51dc into huggingface:master May 18, 2024
2 checks passed
@officialcjunior officialcjunior deleted the store-limits-devices branch May 18, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants