Add missing type-hints in SetFitTrainer
#397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gabriel Martin <gmartinbdev@gmail.com>
|
These are some strange errors... Not sure why it does work on 3.7. Can't easily reproduce this as it uses CUDA for me locally. |
|
I still can't reproduce it when forcing the model to CPU before sending it through openvino. |
|
Hmm true, just changed the type-hints but didn't look at the errors, I can dig deeper if needed, just let me know if you need a helping hand 馃槃 @tomaarsen |
|
Fixed the CI issues, thanks for these code quality improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi to whoever is reading this! 馃
What's in this PR?
This PR adds some missing type-hints in
SetFitTrainer, as spotted while playing around withsetfitwith @gabrielmbmb