Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix tokenizers with both withespace and metaspace #96

Merged
merged 2 commits into from
Nov 29, 2023
Merged

fix: fix tokenizers with both withespace and metaspace #96

merged 2 commits into from
Nov 29, 2023

Conversation

OlivierDehaene
Copy link
Member

Close #94

@OlivierDehaene OlivierDehaene mentioned this pull request Nov 29, 2023
Closed
4 tasks
ArthurZucker
ArthurZucker approved these changes Nov 29, 2023
View reviewed changes
Copy link

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, think we might have a similar issues with the WhiteSpace pretokenizer

@OlivierDehaene OlivierDehaene merged commit 8067a80 into main Nov 29, 2023
6 checks passed
@OlivierDehaene OlivierDehaene deleted the fix/fix_multi branch November 29, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Difference in embedding when comparing SentenceTransformer vs TEI 0.4.0 and up for multilingual-e5-large
2 participants
@OlivierDehaene @ArthurZucker