Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max_total_tokens #65

Closed
OlivierDehaene opened this issue Feb 14, 2023 · 0 comments · Fixed by #68
Closed

Add max_total_tokens #65

OlivierDehaene opened this issue Feb 14, 2023 · 0 comments · Fixed by #68

Comments

@OlivierDehaene
Copy link
Member

Right now it is possible to have input_length + max_new_tokens go over the model token limit.
Add a max_total_tokens validation step or add a new finish reason.

@lewtun
@OlivierDehaene OlivierDehaene mentioned this issue Feb 15, 2023
Merged
OlivierDehaene added a commit that referenced this issue Feb 15, 2023
@OlivierDehaene
feat(router): add max_total_tokens and empty_input validation (#68)
5437d49 
closes #65
sywangyi pushed a commit to sywangyi/text-generation-inference that referenced this issue Mar 12, 2024
@jkaniecki @szutenberg
Improve habana profile dev experience (huggingface#36) (huggingface#65)
9ad6086 
Co-authored-by: Michal Szutenberg <37601244+szutenberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(router): add max_total_tokens and empty_input validation huggingface/text-generation-inference
1 participant
@OlivierDehaene