Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate ld.so.cache #1708

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Regenerate ld.so.cache #1708

merged 1 commit into from
Apr 8, 2024

Conversation

oOraph
Copy link
Contributor

@oOraph oOraph commented Apr 5, 2024

fixes #1711

This file is mandatory for programs to know where to look where to find dynamic linked libraries
The problem arise within containers that add .so files to the container during the OCR definition
If we consider nvidia-container-runtim, these .so for example concern cuda libs, nvidia drivers, so that the versions on both the host and
the guest/container are consistent, to avoid version conflict as much as possible, and provide additional tools, like nvidia-smi,
by default)
If ldconfig is not run as a precommand then the latest added libs are not cached
This does not happen with the nvidia-container-runtime because it runs ldconfig
Looks like for some reason the GKE container runtime does not
The provided command should be enough to fix most issues

Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XciD
Copy link
Member

XciD commented Apr 8, 2024

Merging for today release

@XciD XciD merged commit 53c2c3d into huggingface:main Apr 8, 2024
3 of 7 checks passed
oOraph added a commit to oOraph/text-generation-inference that referenced this pull request Apr 8, 2024
kdamaszk pushed a commit to kdamaszk/tgi-gaudi that referenced this pull request Apr 29, 2024
fixes
huggingface#1711

Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
Co-authored-by: Raphael Glon <oOraph@users.noreply.github.com>
Nilabhra pushed a commit to TII-AI-Research-Center/text-generation-inference that referenced this pull request May 14, 2024
fixes
huggingface#1711

Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
Co-authored-by: Raphael Glon <oOraph@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TGI cannot run properly on GKE
4 participants