Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update xpu docker image and use public ipex whel #1860

Merged
merged 1 commit into from
May 6, 2024

Conversation

sywangyi
Copy link
Contributor

@sywangyi sywangyi commented May 6, 2024

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@sywangyi
Copy link
Contributor Author

sywangyi commented May 6, 2024

@Narsil @OlivierDehaene @mfuntowicz @yao-matrix please have review

Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I will for ahead and merge this.
Subsequent PRs should show the status for this docker image, we could also rebase after to get the tests up& running: #1832

@Narsil Narsil merged commit 59b3ffe into huggingface:main May 6, 2024
1 check failed
@paulcx
Copy link

paulcx commented May 7, 2024

Why is the size of a CPU image (sha-ac7076b-intel) approximately 47.3 GB?

@sywangyi
Copy link
Contributor Author

sywangyi commented May 7, 2024

with the PR, the docker image is dropped to 26.5GB

@paulcx
Copy link

paulcx commented May 7, 2024

Another question, is it normal that the speed on CPU (Xeon(R) Gold 6442Y) is 20 times slower than on GPU (A6000) currently?

@yao-matrix
Copy link

Another question, is it normal that the speed on CPU (Xeon(R) Gold 6442Y) is 20 times slower than on GPU (A6000) currently?

Could you elaborate the benchmark case? Like you use which script and what configurations? From FLOPS performance, 6442Y has AMX and 24 cores(which means it's a middle end CPU, spec is here), one 6442Y socket BF16 TFLOPS is ~1/3 of A6000(spec is here). So more details on benchmark is needed to verify if your 1/20 is reasonable.

@paulcx
Copy link

paulcx commented May 7, 2024

Just did a simple test with the same prompt (outputting around 100 tokens) using a rough calculation method on tgi api (using api docs). A6000 took ~2 seconds while 6442Y needed ~40 seconds. Do you have any benchmark results using CPU image that can be shared?

Nilabhra pushed a commit to TII-AI-Research-Center/text-generation-inference that referenced this pull request May 14, 2024
# What does this PR do?

<!--
Congratulations! You've made it this far! You're not quite done yet
though.

Once merged, your PR is going to appear in the release notes with the
title you set, so make sure it's a great title that fully reflects the
extent of your awesome contribution.

Then, please replace this with a description of the change and which
issue is fixed (if applicable). Please also include relevant motivation
and context. List any dependencies (if any) that are required for this
change.

Once you're done, someone will review your PR shortly (see the section
"Who can review?" below to tag some potential reviewers). They may
suggest changes to make the code even better. If no one reviewed your PR
after a week has passed, don't hesitate to post a new comment
@-mentioning the same persons---sometimes notifications get lost.
-->

<!-- Remove if not applicable -->

Fixes # (issue)


## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the
other checks if that's the case).
- [ ] Did you read the [contributor
guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests),
      Pull Request section?
- [ ] Was this discussed/approved via a Github issue or the
[forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case.
- [ ] Did you make sure to update the documentation with your changes?
Here are the
[documentation
guidelines](https://github.com/huggingface/transformers/tree/main/docs),
and
[here are tips on formatting
docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?


## Who can review?

Anyone in the community is free to review the PR once the tests have
passed. Feel free to tag
members/contributors who may be interested in your PR.

<!-- Your PR will be replied to more quickly if you can figure out the
right person to tag with @


@OlivierDehaene OR @Narsil

 -->

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@sywangyi
Copy link
Contributor Author

Hi, @paulcx could you try #1936 for cpu performance.

@sywangyi sywangyi deleted the xpu_upgrade branch June 5, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants