Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falcon/DBRX: get correct number of key-value heads #2205

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

danieldk
Copy link
Member

@danieldk danieldk commented Jul 8, 2024

What does this PR do?

Falcon: get correct number of key-value heads. We should really get this from the models.

Draft: need to check another model.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@danieldk danieldk force-pushed the bugfix/falcon-num-kv-heads branch from 6ae4b1c to 9c33cf5 Compare July 8, 2024 09:56
@danieldk danieldk marked this pull request as draft July 8, 2024 10:03
@danieldk danieldk force-pushed the bugfix/falcon-num-kv-heads branch from 9c33cf5 to 98f14b7 Compare July 8, 2024 11:04
@danieldk danieldk changed the title Falcon: get correct number of key-value heads Falcon/DBRX: get correct number of key-value heads Jul 8, 2024
@danieldk danieldk marked this pull request as ready for review July 8, 2024 11:04
@danieldk danieldk merged commit 5c7c9f1 into main Jul 8, 2024
8 checks passed
@danieldk danieldk deleted the bugfix/falcon-num-kv-heads branch July 8, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant