Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing conda ssl location #1124

Merged
merged 9 commits into from
Dec 19, 2022
Merged

Fixing conda ssl location #1124

merged 9 commits into from
Dec 19, 2022

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Dec 19, 2022

Fix #1121

openssl crate uses pkg-config to find libssl, which ended finding the host libssl instead of a conda one.

Adding openssl and pkg-config to the conda deps make sure ssl is available.

yum install openssl-dev is necessary for wget the miniconda, removing it afterwards makes sure we're not linking against system libssl.

@Narsil Narsil changed the title Fixing #1121 Fixing conda ssl location Dec 19, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 19, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sounds good to me! Good catch

@Narsil Narsil merged commit 1649d74 into main Dec 19, 2022
@Narsil Narsil deleted the conda_build branch December 19, 2022 12:50
Narsil added a commit that referenced this pull request Jan 16, 2023
* Fixing conda build ?

* Reduce the scope to speedup testing.

* Reduce more.

* Trying to link to conda lib.

* Trying to enable `pkg-config` on the codna env.

* Really publish.

* Update conda builds.

* Remove 3.11

* Putting releases back onto release track.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda installation is broken
3 participants