-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] In CharBPETokenizer, when Vocab or merges is None, unk_token cannot be used. #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In SentencePieceBPETokenizer, when Vocab or merges is None, unk_token cannot be used.
…e_bpe.py Co-authored-by: Nicolas Patry <patry.nicolas@protonmail.com>
In CharBPETokenizer, when Vocab or merges is None, unk_token cannot be used.
The documentation is not available anymore as the PR was closed or merged. |
Narsil
reviewed
Dec 26, 2022
bindings/python/py_src/tokenizers/implementations/char_level_bpe.py
Outdated
Show resolved
Hide resolved
…pe.py Co-authored-by: Nicolas Patry <patry.nicolas@protonmail.com>
Narsil
reviewed
Dec 27, 2022
bindings/python/py_src/tokenizers/implementations/char_level_bpe.py
Outdated
Show resolved
Hide resolved
…pe.py Co-authored-by: Nicolas Patry <patry.nicolas@protonmail.com>
Narsil
approved these changes
Dec 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for this
Narsil
added a commit
that referenced
this pull request
Jan 16, 2023
…nnot be used. (#1136) * [fix] Use unk_token In SentencePieceBPETokenizer, when Vocab or merges is None, unk_token cannot be used. * [fix] If unk_token is None, this case is also considered. * Update bindings/python/py_src/tokenizers/implementations/sentencepiece_bpe.py Co-authored-by: Nicolas Patry <patry.nicolas@protonmail.com> * [FIX] In CharBPETokenizer, Use unk_token. In CharBPETokenizer, when Vocab or merges is None, unk_token cannot be used. * Update bindings/python/py_src/tokenizers/implementations/char_level_bpe.py Co-authored-by: Nicolas Patry <patry.nicolas@protonmail.com> * Update bindings/python/py_src/tokenizers/implementations/char_level_bpe.py Co-authored-by: Nicolas Patry <patry.nicolas@protonmail.com> Co-authored-by: Nicolas Patry <patry.nicolas@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same Error #1120
Thanks.
before
char_level_bep.py
main.py
after
char_level_bep.py
main.py