Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: add binding for original string #118

Merged
merged 2 commits into from Feb 3, 2020
Merged

node: add binding for original string #118

merged 2 commits into from Feb 3, 2020

Conversation

Pierrci
Copy link
Member

@Pierrci Pierrci commented Jan 31, 2020

Closes #96

@Pierrci Pierrci requested a review from n1t0 January 31, 2020 23:11
n1t0
n1t0 approved these changes Feb 2, 2020
View reviewed changes
Copy link
Member

@n1t0 n1t0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Pierrci! Very thorough testing!

I just pushed a quick tweak to avoid having to clone the NormalizedString before getting the part of the original string.

@n1t0 n1t0 merged commit 27880b3 into master Feb 3, 2020
@n1t0 n1t0 deleted the node-original-string branch February 3, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n1t0 n1t0 n1t0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide original_str in node bindings
2 participants
@Pierrci @n1t0