Adding 2 new decoders: #1196
Merged
Adding 2 new decoders: #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Mar 23, 2023
| assert Strip(left=0, right=0) is not None | ||
| assert isinstance(Strip(left=0, right=0), Decoder) | ||
| assert isinstance(Strip(left=0, right=0), Strip) | ||
| # assert isinstance(pickle.loads(pickle.dumps(Strip(left=0, right=0))), Strip) |
There was a problem hiding this comment.
Same here, to remove or fix?
There was a problem hiding this comment.
Hoped it would go unoticed :)
Pickling is a nice touch, but cumbersome.
- Fuse will simply concatenate all tokens into 1 string
- Strip will remove n char from left or right
Sequence(Replace("_", " "), Fuse(), Strip(1, 0)) should be what we want
for the `Metaspace` thing.
- Note: Added a new dependency from better parsing of decoders.
This is due to untagged enums which can match anything the `MustBe`
ensure there's no issue between Fuse and ByteFallback.
Since both are new the chances for backward incompatibility is low.
Narsil
force-pushed
the
lstrip_fuse_decoder
branch
from
597017e
to
c943c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequence(Replace("_", " "), Fuse(), Strip(1, 0)) should be what we want
for the
Metaspacething.This is due to untagged enums which can match anything the
MustBeensure there's no issue between Fuse and ByteFallback.
Since both are new the chances for backward incompatibility is low.