Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve models builders #190

Merged
merged 5 commits into from
Mar 6, 2020
Merged

Improve models builders #190

merged 5 commits into from
Mar 6, 2020

Conversation

n1t0
Copy link
Member

@n1t0 n1t0 commented Mar 6, 2020

  • from_files now returns a builder, and cannot fail
  • All possible failures are handled during the build phase of each builder
  • This also moves any I/O to the build phase. This behavior seems more intuitive: we first construct our builders with all their respective configurations and then finally build at the end, doing the real work only then.
  • This simplifies both python and node bindings where we don't need to have any default values.
  • Add the continuing_subword_prefix option to both bindings for WordPiece.

@n1t0 n1t0 requested a review from Pierrci March 6, 2020 17:28
@epwalsh
Copy link
Collaborator

epwalsh commented Mar 6, 2020

I like this! I think it's definitely a good convention.

@Pierrci
Copy link
Member

Pierrci commented Mar 6, 2020

👍

@n1t0 n1t0 merged commit 6d6e72b into master Mar 6, 2020
@n1t0 n1t0 deleted the improve-models-builders branch March 6, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants