Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RobertaProcessing deserialization in PostProcessorWrapper #464

Merged
merged 1 commit into from Oct 15, 2020

Conversation

n1t0
Copy link
Member

@n1t0 n1t0 commented Oct 14, 2020

When loading a Tokenizer from a json file, if it contains a RobertaProcessing, it ends up deserialized as a BertProcessing.

This happens because serde does not validate tags, when wrapped in an untagged enum (just like we do for PostProcessorWrapper).

@n1t0 n1t0 merged commit 2fc0edd into master Oct 15, 2020
@n1t0 n1t0 deleted the fix-roberta-serde branch October 15, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant