Fix word level tokenizer determinism #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @n1t0, did you have a chance to have a look at this? |
n1t0
force-pushed
the
fix_word_level_determinism
branch
from
5e35944
to
9538bde
Compare
n1t0
approved these changes
Aug 13, 2021
There was a problem hiding this comment.
Awesome, thank you for taking care of this @lucacampanella!
I just fixed a few Clippy warnings and added a missing import at the beginning. Everything is working perfectly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #717
If two word level tokens have the same counts, their order is determined by the token itself alphabetically. This allows for determinism in the resulting tokenizer.
I have tested the code only in the online playground of rust (here), as setting up everything on my system would take too much time. I thus didn't run any tests.
Thanks for taking a look at this. :)