Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify initialization of BpeTrainer #8

Merged
merged 1 commit into from Dec 24, 2019
Merged

simplify initialization of BpeTrainer #8

merged 1 commit into from Dec 24, 2019

Conversation

epwalsh
Copy link
Collaborator

@epwalsh epwalsh commented Dec 23, 2019

Given that BpeTrainer only has two fields, I think it makes more sense just to make those fields pub and remove the BpeTrainerConfig object.

@epwalsh epwalsh requested a review from n1t0 December 23, 2019 22:42
@n1t0
Copy link
Member

n1t0 commented Dec 24, 2019

Perfect! Thank you @epwalsh!

@n1t0 n1t0 merged commit c0ed873 into master Dec 24, 2019
@n1t0 n1t0 deleted the struct-initialization branch December 24, 2019 01:13
@Mansterteddy Mansterteddy mentioned this pull request Jan 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n1t0 n1t0 Awaiting requested review from n1t0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@epwalsh @n1t0