Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bigscience/bloomz #25

Merged
merged 15 commits into from Nov 7, 2022
Merged

Add support for bigscience/bloomz #25

merged 15 commits into from Nov 7, 2022

Conversation

mayank31398
Copy link
Collaborator

No description provided.

Copy link
Contributor

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayank31398 looks great, just a few minor comments

inference_server/utils/requests.py Show resolved Hide resolved
inference_server/model_handler/deployment.py Show resolved Hide resolved
inference_server/model_handler/deployment.py Show resolved Hide resolved
inference_server/model_handler/deployment.py Outdated Show resolved Hide resolved
Copy link
Contributor

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed one more small thing

elif model_name == DS_INFERENCE_BLOOM_INT8:
return "int8"


def get_torch_dtype(dtype_str: str) -> torch.dtype:
if dtype_str == "bf16":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The type hints in the get_str_dtype func below are the wrong way around. It should take a torch.dtype and return a str

Comment on lines 4 to 6
from .ds_inference import DSInferenceModel
from .ds_zero import DSZeROModel
from .hf_accelerate import HFAccelerateModel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be good to conditionally import these to avoid depending on non-required libraries when only one of them is used

@mayank31398 mayank31398 merged commit b07f9f7 into main Nov 7, 2022
@mayank31398 mayank31398 deleted the mayank/bloomz branch November 7, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants