Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracker: generate compatibility with torch.compile #28981

Open
3 of 27 tasks
gante opened this issue Feb 12, 2024 · 2 comments
Open
3 of 27 tasks

tracker: generate compatibility with torch.compile #28981

gante opened this issue Feb 12, 2024 · 2 comments
Assignees
Labels
WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress

Comments

@gante
Copy link
Member

gante commented Feb 12, 2024

generate 馃 馃 torch.compile

This issue is a tracker of the compatibility between .generate and torch.compile (intro docs by pytorch). The goal is to enable fullgraph=True compilation on the main generate use cases.

鈿狅笍 Is your generate use case not covered by this tracker? Check if it was requested below and upvote it if it was. Otherwise, add a comment. We will consider expanding the selection below on widely requested use cases 馃

Decoding Strategies

  • greedy_search / sample are compatible (Generate: end-to-end compilation聽#30788)
  • beam_search / beam_sample are compatible, depends on the step above
  • assisted_decoding (aka speculative decoding) is compatible, depends on the steps above

Generate Flags and Options

  • all LogitsProcessor classes were checked for compatibility (and the appropriate exceptions are raised when not compatible)
  • all StoppingCriteria classes were checked for compatibility (and the appropriate exceptions are raised when not compatible)

Models

(models tagged as "important models" in our CI + popular models)

Decoder-only:

Encoder-decoder:

Quantization

  • BNB support
  • GPTQ support
  • AWQ support

Others

  • We have a benchmark script to quickly compare the impact of PRs
  • Add section to existing docs on the topic
  • Confirm that pipelines work after compiling generate
@gante gante changed the title generate compatibility with torch.compile tracker: generate compatibility with torch.compile Feb 12, 2024
@gante gante self-assigned this Feb 12, 2024
@gante gante mentioned this issue Mar 14, 2024
26 tasks
@huggingface huggingface deleted a comment from github-actions bot Mar 25, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@gante gante reopened this May 2, 2024
@ArthurZucker ArthurZucker added the WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress label May 9, 2024
@kadirnar
Copy link
Contributor

馃憖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress
Projects
None yet
Development

No branches or pull requests

3 participants