-
Notifications
You must be signed in to change notification settings - Fork 25.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GroundingDino - Loss calculation exceptions #31434
Comments
Hey @amyeroberts, are you the relevant person for this bug? I have further questions, if possible:
Thanks! |
cc @EduardoPach |
TL;DR I will work to fix this during this week :) Hey, thanks for the opening the issue! The implementation of GroundingDinoLoss is not actually correct and when adding the model I didn't focused that much on making it right as the original repo doesn't have training code or the loss calculation. That being said I found an issue in the original repo where authors point to other repos that implement the training for Grounding DINO so I will use that and check with the paper to fix this :) |
Thanks @EduardoPach! I'll be happy to assist as needed. Could you point me to the reference implementations you've mentioned? |
Any update @EduardoPach? |
I have added the corrections (haven't created the PR yet) I just need to test them know. I will probably do that during the weekend |
System Info
transformers==4.40.2
Python 3.10.14
Ubuntu WSL under Windows 10
Who can help?
@amyeroberts
Information
Tasks
examples
folder (such as GLUE/SQuAD, ...)Reproduction
I've been trying to fine tune GroundingDino with transformers' GroundingDinoForObjectDetection. To ease things I've been using batch_size = 1.
(I haven't tried with any other batch sizes)
When running the model, I got this exception:
(There were indeed 3 bounding boxes in the label data)
Expected behavior
Loss should be calculated with no errors
The text was updated successfully, but these errors were encountered: