Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check diff files in check_copies #31509

Open
zucchini-nlp opened this issue Jun 20, 2024 · 0 comments
Open

Check diff files in check_copies #31509

zucchini-nlp opened this issue Jun 20, 2024 · 0 comments
Labels
Feature request Request for a new feature

Comments

@zucchini-nlp
Copy link
Member

zucchini-nlp commented Jun 20, 2024

Feature request

As mentioned in this comment we want to check that files generated by diff are not changed whenever we run make fix-copies. That way we can catch if there are any any changes in super classes that aren't being propagated to the diff child.

Motivation

Repo consistency checks

Your contribution

Tagging @ArthurZucker for diff and maybe @ydshieh for repo consistency check. I will be very slow if I start adding this

@zucchini-nlp zucchini-nlp added the Feature request Request for a new feature label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

1 participant