Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed forward chunking for all pretrained models #5928

Closed
Pradhy729 opened this issue Jul 21, 2020 · 5 comments
Closed

Feed forward chunking for all pretrained models #5928

Pradhy729 opened this issue Jul 21, 2020 · 5 comments
Labels

Comments

@Pradhy729
Copy link
Contributor

Based on this card: Feed forward chunking

@patrickvonplaten

I'd like to help contribute and implement this for all the other models if this is still pending?

@Pradhy729
Copy link
Contributor Author

Any opinions here? I will create a PR if there is interest and would like to get your ideas and suggestions. @patrickvonplaten @sshleifer

@sshleifer
Copy link
Contributor

@patrickvonplaten would be the point person and he is on Vacation until August 3.
In the interim, if you want to start working on this go right ahead. Make sure it's actually faster/needed before you start though. I don't really know.

@patrickvonplaten
Copy link
Contributor

Hey @Pradhy729,

Yes it would be great to start a PR to add feed forward chunking to other models. Maybe you can start with BERT in your PR and ping us to get Feedback :-)

A couple of things to consider:

  1. You should probably move the config param config.chunk_size_feed_forward to the general configuration_utils.py file.

  2. As @sshleifer said it would be good to benchmark the gains in a very similar way to this Notebook:
    https://github.com/patrickvonplaten/notebooks/blob/master/Reformer_2_4.ipynb

  3. as said earlier we should start with BERT and config.chunk_size_feed_forward.

@Pradhy729
Copy link
Contributor Author

Awesome! I will start with BERT and share with you for feedback.

@stale
Copy link

stale bot commented Sep 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 24, 2020
@stale stale bot closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants