Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] fix imports #1527

Merged
merged 1 commit into from
Apr 12, 2024
Merged

[CLI] fix imports #1527

merged 1 commit into from
Apr 12, 2024

Conversation

kashif
Copy link
Collaborator

@kashif kashif commented Apr 12, 2024 •
edited
Loading

fixes #1469

younesbelkada
younesbelkada approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch ! will make a patch release to include this!
This might fix: #1469

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@younesbelkada younesbelkada mentioned this pull request Apr 12, 2024
Closed
@younesbelkada younesbelkada merged commit 87f4c70 into main Apr 12, 2024
9 checks passed
@younesbelkada younesbelkada deleted the kashif-patch-1 branch April 12, 2024 10:17
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
@kashif
[CLI] fix imports (huggingface#1527)
802c7dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesbelkada younesbelkada younesbelkada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

from trl import SFTTrainer getting issue
3 participants
@kashif @HuggingFaceDocBuilderDev @younesbelkada