[core] Fix DeepSpeed zero-3 issue
#182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
pacman100
reviewed
Mar 27, 2023
There was a problem hiding this comment.
Thank you @younesbelkada for fixing TRL+DS integration. Left comment. Sentiment pipeline related changes have shared offline.
trl/trainer/ppo_trainer.py
Outdated
| ) = self.accelerator.prepare( | ||
| self.model, self.ref_model, self.optimizer, self.data_collator, self.dataloader, self.lr_scheduler | ||
| # Safety checkers for DS integration | ||
| is_deepspeed_zero_3 = ( |
There was a problem hiding this comment.
This changes is irrespective of DS Stage, it should be applied for all DS Stages
Co-authored-by: Sourab Mangrulkar <13534540+pacman100@users.noreply.github.com>
younesbelkada
commented
Mar 27, 2023
Comment on lines
+291
to
+292
| if self.accelerator.state.deepspeed_plugin.zero_stage == 3: | ||
| self.model.train() |
There was a problem hiding this comment.
Based on the offline discussion I had with @pacman100 , I confirm this hack is needed to make DS3 work
younesbelkada
requested review from
pacman100 and
lvwerra
and removed request for
pacman100
lvwerra
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is an attempt to fix #171
For now the sentiment script hangs, so I need to investigate