Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added doc for using torch.distributed.launch/run #324

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

oroojlooy
Copy link
Contributor

Following up on #317, I created this PR.

@oroojlooy oroojlooy mentioned this pull request Apr 26, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 26, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this!
For some reason the diff also shows that you have added the paragraph ### Run on multiple GPUs / node, but it seems that everything is correct as expected when looking at the generated documentation. Could you maybe merge your branch with trl's main branch?

cc @lvwerra

docs/source/customization.mdx Outdated Show resolved Hide resolved
@oroojlooy
Copy link
Contributor Author

Thanks a lot for this! For some reason the diff also shows that you have added the paragraph ### Run on multiple GPUs / node, but it seems that everything is correct as expected when looking at the generated documentation. Could you maybe merge your branch with trl's main branch?

cc @lvwerra

That was weird for me as well. I cloned the repo this morning to have a clean commit. Do you want me to re-do that with a new clone?

@younesbelkada
Copy link
Collaborator

I have updated your branch for you! Will merge once it is green

@younesbelkada younesbelkada merged commit 08f5506 into huggingface:main Apr 28, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants