Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap FTBFS #307

Closed
lfaraone opened this issue Nov 2, 2018 · 2 comments
Closed

Snap FTBFS #307

lfaraone opened this issue Nov 2, 2018 · 2 comments

Comments

@lfaraone
Copy link
Contributor

lfaraone commented Nov 2, 2018

https://build.snapcraft.io/user/huggle/huggle3-qt-lx/367169

DEPRECATED: The 'prepare' keyword has been replaced by 'override-build'
See http://snapcraft.io/docs/deprecation-notices/dn7 for more information.
Skipping pull desktop-qt5 (already ran)
Skipping pull application (already ran)
Skipping build desktop-qt5 (already ran)
Building application 
/bin/sh: 39: ./build/prepare_snap.sh: not found
Failed to run 'prepare': Exit code was 127.

Looks like there's a path issue?

@benapetr
Copy link
Member

benapetr commented Nov 2, 2018

Yes, but I have no idea why it suddenly stopped working

The file is located in src/build/prepare_snap.sh

No idea what path should be in snapcraft.yml for it to work, the thing changes too quickly for me to keep pace

@benapetr
Copy link
Member

benapetr commented Nov 2, 2018

Basically the reason for this script to exist is that older versions of snapcraft were not able to check out repository recursively, and this repo is full of submodules. Other thing it does is that it generate version.txt file and copies "definitions_prod.hpp" to definitions.hpp, which is step typically done by "configure" script, but in case you want to build huggle using CMake directly, without invoking configure script, you need to do that by hand.

#!/bin/sh

# Old git requires these commands to run from repo root
cd ../src || exit 1
echo "Preparing in `pwd`"
git submodule init
git submodule update
cd huggle_core || exit 1
# Generate version.txt
sh update.sh
cp definitions_prod.hpp definitions.hpp || exit 1

benapetr pushed a commit that referenced this issue Nov 3, 2018
Closes #307

Handle path differences that changed in between versions of ``snapcraft``.
Drop explicit submodule handling in favour of ``source-type: git``.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants