Fix 'Icon not present' on linux #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All wikis have a Special:BotPasswords page.
As I can see in the logs during the install the file is copied at /usr/local/share/huggle/huggle3_newlogo.png, so let's define this path in the huggle.desktop file. It's works fine for me. Bug: https://phabricator.wikimedia.org/T114866
|
Which OS did you try this on? It's not actually that simple, for example from what I remember debian packaging put this file into /usr/share/huggle/huggle3_newlogo.png So while this fixes the "make install" it probably breaks the deb packaging, but it probably doesn't matter as that is using separate branch anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I can see in the logs during the install the file is copied at /usr/local/share/huggle/huggle3_newlogo.png, so let's define this path in the huggle.desktop file. It's works fine for me.
Bug: https://phabricator.wikimedia.org/T114866