Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Core updates #4

Merged
merged 1 commit into from Aug 3, 2016
Merged

.NET Core updates #4

merged 1 commit into from Aug 3, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jul 25, 2016

@hughbe
Copy link
Owner

hughbe commented Jul 26, 2016

Thanks so much for this @jasonwilliams200OK

I'm travelling around Europe ATM without a laptop so can't build this locally. I assume you've built everything but a simple confirmation would be great!

Meanwhile I'll take a look at the PR in the next few days when I have time

Thanks again

@ghost
Copy link
Author

ghost commented Jul 27, 2016

@hughbe, yup I validated the changes on Windows, Unix and configured CI to verify.

@hughbe
Copy link
Owner

hughbe commented Aug 3, 2016

I've come back, taken a look - it all looks good! Thanks

@hughbe hughbe merged commit 56b0d4f into hughbe:master Aug 3, 2016
@ghost
Copy link
Author

ghost commented Aug 3, 2016

@hughbe, thanks! Could you please sign in with your GitHub on AppVeyor and add this project so this https://ci.appveyor.com/project/hughbe/html-generator/branch/master light up? Also, on TravisCI https://travis-ci.org/hughbe/html-generator for Unix builds. :)

@hughbe
Copy link
Owner

hughbe commented Aug 3, 2016

Thanks - all done!

hughbe pushed a commit that referenced this pull request Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant