Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong symbols versioning? #27

Closed
bigon opened this issue Feb 11, 2020 · 4 comments · Fixed by #28
Closed

Wrong symbols versioning? #27

bigon opened this issue Feb 11, 2020 · 4 comments · Fixed by #28

Comments

@bigon
Copy link
Contributor

bigon commented Feb 11, 2020

Hello,

Are there some errors in the symbols versioning in 0.3.3 (again)?

There are a bunch of new symbols that have the version 0.1.0

g_usb_endpoint_get_number@LIBGUSB_0.1.0
g_usb_endpoint_get_refresh@LIBGUSB_0.1.0
g_usb_endpoint_get_synch_address@LIBGUSB_0.1.0
g_usb_endpoint_get_type@LIBGUSB_0.1.0
g_usb_version_string@LIBGUSB_0.1.0
@EmmanuelP
Copy link
Contributor

EmmanuelP commented Feb 11, 2020

g_usb_endpoint_get_number@LIBGUSB_0.1.0
g_usb_endpoint_get_refresh@LIBGUSB_0.1.0
g_usb_endpoint_get_synch_address@LIBGUSB_0.1.0
g_usb_endpoint_get_type@LIBGUSB_0.1.0

That's my fault, I guess. Does that mean libgusb.ver file should be updated ? What is the purpose of this file ?

@bigon
Copy link
Contributor Author

bigon commented Feb 11, 2020

It's used to be able to do versioning of the symbols

The problem is that if an application is using this symbol and that the version is changed the application will fail to start because it will think the symbol is missing

If there are no consumer of these functions in the wild I guess it's fine to do the change

@hughsie
Copy link
Owner

hughsie commented Feb 11, 2020

I guess it's fine to do the change

Yes, sorry I missed this. It needs to be in the right place in the .ver file. @EmmanuelP could you have a go for me please?

@EmmanuelP
Copy link
Contributor

@hughsie I will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants