-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let default table inherit the boostrap #table css style #1883
Conversation
@@ -27,6 +27,10 @@ body { padding-top: 60px; } | |||
margin-bottom: 100px; | |||
} | |||
|
|||
table { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be inside of .well.description
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cantino ,I tried it, and it can work. It only affect in markdown-table of agent's description when the code inside of .well.description. On the contrary, it affect the whole table.
So should I make a new PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have tables outside of Agent descriptions that you're trying to style, or am I misunderstanding you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I just want to style agent descriptions this time, so maybe we should make the code inside of .well.description this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought It doesn't matter even if we make the code outside of .well.description to affect the whole table, because the default table normally should style.
But now, I think we should change the code conservatively, because maybe there are other default tables own their style, if we change the hole table, maybe it happen something that we can't expect.
So maybe we should make the code only inside of .well.description this time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that makes sense. Want to update this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I update this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cantino , I have update the PR^^
Thanks @tsaohucn! |
Fixes #1795.
let the markdown can show the table like the picture.
|-----------------+------------+-----------------+----------------|