Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let default table inherit the boostrap #table css style #1883

Merged
merged 2 commits into from
Jan 28, 2017

Conversation

tsaohucn
Copy link
Contributor

@tsaohucn tsaohucn commented Jan 24, 2017

Fixes #1795.

let the markdown can show the table like the picture.

|-----------------+------------+-----------------+----------------|

Default aligned Left aligned Center aligned Right aligned
First body part Second cell Third cell fourth cell
Second line foo strong baz
Third line quux baz bar
-----------------+------------+-----------------+----------------
Second body
2 line
=================+============+=================+================
Footer row
-----------------+------------+-----------------+----------------

2017-01-24 3 04 22

@@ -27,6 +27,10 @@ body { padding-top: 60px; }
margin-bottom: 100px;
}

table {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be inside of .well.description?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cantino ,I tried it, and it can work. It only affect in markdown-table of agent's description when the code inside of .well.description. On the contrary, it affect the whole table.
So should I make a new PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have tables outside of Agent descriptions that you're trying to style, or am I misunderstanding you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I just want to style agent descriptions this time, so maybe we should make the code inside of .well.description this time.

Copy link
Contributor Author

@tsaohucn tsaohucn Jan 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought It doesn't matter even if we make the code outside of .well.description to affect the whole table, because the default table normally should style.

But now, I think we should change the code conservatively, because maybe there are other default tables own their style, if we change the hole table, maybe it happen something that we can't expect.

So maybe we should make the code only inside of .well.description this time

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense. Want to update this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I update this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cantino , I have update the PR^^

@cantino cantino merged commit 80debd6 into huginn:master Jan 28, 2017
@cantino
Copy link
Member

cantino commented Jan 28, 2017

Thanks @tsaohucn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants