Add more options to the GrowlAgent #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now additionally allows to use `sticky`, `priority` and `callback_url`. The Agent is now `FormConfigurable` and supports Liquid in all options. `register_growl` had to be moved inside of the `events` loop to allow Liquid interpolation for the previously static `growl_*` options. huginn#2018
knu
approved these changes
Aug 1, 2017
|
Me neither until a few days ago 😄 Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now additionally allows to use
sticky,priorityandcallback_url. The Agent is nowFormConfigurableand supports Liquid in all options.register_growlhad to be moved inside of theeventsloop to allow Liquid interpolation for the previously staticgrowl_*options.#2018