Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not treat already retweeted/favorited error as failure #2140

Merged
merged 1 commit into from
Oct 11, 2017

Conversation

knu
Copy link
Member

@knu knu commented Oct 10, 2017

There's no use to retry when those errors occur, so just log an error message and let it go.

There's no use to retry when those errors occur, so just log an error
message and let it go.
@knu knu requested a review from dsander October 10, 2017 11:57
@knu
Copy link
Member Author

knu commented Oct 10, 2017

The other day I found my job queue filled up with failed TwitterActionAgent jobs saying "You have already retweeted this tweet." All I could do was just delete them one by one. 😣

Copy link
Collaborator

@dsander dsander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@knu knu merged commit 509528f into master Oct 11, 2017
@knu knu deleted the ignore_twitter_action_duplicate_error branch October 11, 2017 08:40
@knu
Copy link
Member Author

knu commented Oct 11, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants