Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a workaround for broken AlreadyRetweeted error detection #2155

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Add a workaround for broken AlreadyRetweeted error detection #2155

merged 1 commit into from
Oct 30, 2017

Conversation

knu
Copy link
Member

@knu knu commented Oct 29, 2017

@knu knu requested a review from dsander October 29, 2017 14:15
@knu
Copy link
Member Author

knu commented Oct 30, 2017

@dsander This is a complement to #2140 and I've been running this for several days with success, so I'm merging this!

@knu knu merged commit a2e239e into master Oct 30, 2017
@knu knu deleted the fix_already_retweeted branch October 30, 2017 07:41
@dsander
Copy link
Collaborator

dsander commented Oct 30, 2017

Nice! I noticed the twitter gem added support for the streaming API, if it supports all the feature we need, it could allow us to get rid of the eventmachine dependency. Do you know if there is a use case that requires the em_http faraday backend?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsander dsander Awaiting requested review from dsander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knu @dsander