Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby Gemfile requires ruby >= 2.4, OCP Templates still referenced 2.3 for the image #2726

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Ruby Gemfile requires ruby >= 2.4, OCP Templates still referenced 2.3 for the image #2726

merged 2 commits into from
Mar 30, 2020

Conversation

bttnns
Copy link
Contributor

@bttnns bttnns commented Mar 27, 2020

  • huginn-mysql.json: increased ruby version to latest (2.5 at time of editing)
  • huginn-postgresql.json: increased ruby version to latest (2.5 at time of editing)

Signed-off-by: Brian Tannous brian@briantannous.com
Signed-off-by: Brian Tannous btannous@redhat.com

Co-authored-by: Jason Dobies jdobies@redhat.com
Co-authored-by: JJ Asghar awesome@ibm.com

…ed 2.3 for the image

* huginn-mysql.json: increased ruby version to latest (2.5 at time of editing)
* huginn-postgresql.json: increased ruby version to latest (2.5 at time of editing)

Signed-off-by: Brian Tannous <brian@briantannous.com>
Signed-off-by: Brian Tannous <btannous@redhat.com>

Co-authored-by: Jason Dobies  <jdobies@redhat.com>
Co-authored-by: JJ Asghar <awesome@ibm.com>
Copy link
Collaborator

@dsander dsander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice to see the templates still work in general.

@@ -102,7 +102,7 @@
"from": {
"kind": "ImageStreamTag",
"namespace": "${NAMESPACE}",
"name": "ruby:2.3"
"name": "ruby:latest"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the explicit ruby version here? The latest ruby is 2.7, but we only test against 2.6 at the moment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can. 4.5 is the latest in the OpenShift 4.2 registry for the S2I builder's Ruby image, so Updated accordingly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I am assuming that this ruby:4.5 image is using a ruby version that is supported by Huginn. Can you provide a link to the openshift images for future references? I tried googling it without success 😞

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsander Sure!
For ruby-2.5 specifically: https://github.com/sclorg/s2i-ruby-container/blob/master/2.5/README.md
https://github.com/sclorg/s2i-ruby-container for the main repo and other versions floating around

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…t for OCP4's S2I builder 4.5

Signed-off-by: Brian Tannous <btannous@redhat.com>
@dsander dsander merged commit 96cf503 into huginn:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants