Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSSAgent should record which feed errored and keep going on the other ones #943

Merged
merged 3 commits into from
Aug 1, 2015

Conversation

cantino
Copy link
Member

@cantino cantino commented Jul 29, 2015

@dsander @knu Do you agree with the change that the RSSAgent, when given multiple feeds, should log errors for failed ones but keep going on the others?

Fixes #849

@cantino cantino changed the title the RSSAgent should record which feed errored and keep going on the other ones RSSAgent should record which feed errored and keep going on the other ones Jul 29, 2015
This was referenced Jul 29, 2015
@knu
Copy link
Member

knu commented Aug 1, 2015

@cantino Agreed!

@@ -580,6 +580,3 @@ DEPENDENCIES
weibo_2!
wunderground (~> 1.2.0)
xmpp4r (~> 0.5.6)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I stop this from being removed? I updated bundler and now bundler --version reports Bundler version 1.10.6, but whenever I run bundle, this happens. Oddly, even editing the Gemfile.lock and adding it back in seems to be unable to save the change, like some background process keeps removing it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible you have a old spring instance running?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Ugh, I hate spring.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 08/01/2015 01:16 PM, Andrew Cantino wrote:

Ugh, I hate spring.

Would some benefit be derived from replacing Spring with something
like Zeus or Commands? Or would they not be a good fit for Huginn's
architecture?


The Doctor [412/724/301/703/415] [ZS]

PGP: 0x807B17C1 / 7960 1CDC 85C9 0B63 8D9F DD89 3BD8 FF2B 807B 17C1
WWW: https://drwho.virtadpt.net/

"Shockingly, that didn't work! I can't imagine why!" --Adam Savage

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJVvmOKAAoJED1np1pUQ8RkgYwP/1/zW1TONuf9vMpQhJFO/Yeq
EQDejkIBw0O5Xy99BRulcAQWdBNH9or6jh41vpuSENVyVRpx61d7KseHGz5+tWh0
7PQ61rdM47tjs9ZULTmHbSJKHWH2Qsok7WDqzsAJ6QV3XQNffAQ2L+ilA3EV6ir/
XtnL7inTnGvdhroT366+K+6aD6O12TBnl0+zEi3/PVMmS4YDIJQSM6MP2W61M4Zx
iOCOwfQ1hxfFuEUXbFM0ZNtWTT/lKa38Ceuo/cRgE2viqwGvMqX1gvUNXXCWi2tg
AvG+FawCywEuD4v7di4tb2F+FhgEfnwJj5TZTYepe2IExkT9HRX02X8cp93Gww4s
ryUonvWvd88HojHs9yRg3cvqvl/9fd9rnSJlrxajgt3L9G28+WgZm985jVDr887U
nk3gLCYZ+79JMyleZyiakASqRPdhHuKyX+ZoepwM92nyry856l2Gew+m6Q6KZsRk
5uoWQLvABqSl2AluTR/EEk6kRbsBdnenO9jHENkSuOtXOASjgzYYC9ButoCj7KRi
uhJRGQPmZuOM1P7NVCfzxqp+VcjosBHB7bI9I7jTt8vpq62W2t9iN08KBqTKlebZ
igboh10Ps1OytG7rVAnRUrQXHLFskCqdD4nKAT1kGoBlf8hR3SY/HWr6eQ2EVOnM
GOFls4bcdWT8mK/aU5mx
=NfSI
-----END PGP SIGNATURE-----

cantino added a commit that referenced this pull request Aug 1, 2015
RSSAgent should record which feed errored and keep going on the other ones
@cantino cantino merged commit 3888648 into master Aug 1, 2015
@cantino cantino deleted the rss_agent_logs_exact_feed_on_error branch August 1, 2015 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants