RSSAgent should record which feed errored and keep going on the other ones

app/models/agents/rss_agent.rb

@@ -87,29 +87,35 @@ def events_order
 
     def check
       Array(interpolated['url']).each do |url|
-        response = faraday.get(url)
-        if response.success?
-          feed = FeedNormalizer::FeedNormalizer.parse(response.body)
-          feed.clean! if boolify(interpolated['clean'])
-          max_events = (interpolated['max_events_per_run'].presence || 0).to_i
-          created_event_count = 0
-          sort_events(feed_to_events(feed)).each.with_index do |event, index|
-            break if max_events && max_events > 0 && index >= max_events
-            entry_id = event.payload[:id]
-            if check_and_track(entry_id)
-              created_event_count += 1
-              create_event(event)
-            end
-          end
-          log "Fetched #{url} and created #{created_event_count} event(s)."
-        else
-          error "Failed to fetch #{url}: #{response.inspect}"
-        end
+        check_url(url)
       end
     end
 
     protected
 
+    def check_url(url)
+      response = faraday.get(url)
+      if response.success?
+        feed = FeedNormalizer::FeedNormalizer.parse(response.body)
+        feed.clean! if boolify(interpolated['clean'])
+        max_events = (interpolated['max_events_per_run'].presence || 0).to_i
+        created_event_count = 0
+        sort_events(feed_to_events(feed)).each.with_index do |event, index|
+          break if max_events && max_events > 0 && index >= max_events
+          entry_id = event.payload[:id]
+          if check_and_track(entry_id)
+            created_event_count += 1
+            create_event(event)
+          end
+        end
+        log "Fetched #{url} and created #{created_event_count} event(s)."
+      else
+        error "Failed to fetch #{url}: #{response.inspect}"
+      end
+    rescue => e
+      error "Failed to fetch #{url} with message '#{e.message}': #{e.backtrace}"
+    end
+
     def get_entry_id(entry)
       entry.id.presence || Digest::MD5.hexdigest(entry.content)
     end

spec/models/agents/rss_agent_spec.rb

@@ -148,4 +148,14 @@
       expect(agent.memory['seen_ids']).to eq(agent.events.map {|e| Digest::MD5.hexdigest(e.payload['content']) })
     end
   end
+
+  describe 'logging errors with the feed url' do
+    it 'includes the feed URL when an exception is raised' do
+      mock(FeedNormalizer::FeedNormalizer).parse(anything) { raise StandardError.new("Some error!") }
+      expect(lambda {
+        agent.check
+      }).not_to raise_error
+      expect(agent.logs.last.message).to match(%r[Failed to fetch https://github.com])
+    end
+  end
 end