Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unaligned tables under education #233

Closed
4 of 6 tasks
Roxedus opened this issue Feb 16, 2021 · 7 comments · Fixed by #434
Closed
4 of 6 tasks

Unaligned tables under education #233

Roxedus opened this issue Feb 16, 2021 · 7 comments · Fixed by #434
Labels
hacktoberfest Mark an issue so that contributor participating hacktoberfest can work on it

Comments

@Roxedus
Copy link
Contributor

Roxedus commented Feb 16, 2021

Expected Behavior

Tables under the experience section should align horizontally.

Current Behavior

Tables does not align across institutions. Very apparent with the proposed changes in #231

Possible Solution

On my test setup I altered the education.html to add a class to the <th>{{ i18n "obtained_credit"}}</th> and <td>{{ $course.achieved }}</td> rows, to apply a width of 20% on said class

Steps to Reproduce

Screenshots

image

Browsers Affected

  • Chrome
  • Firefox
  • Edge
  • Safari 11 (Not available)
  • Safari 10 (Not available)
  • IE 11

Detailed Description

@Roxedus Roxedus changed the title bug Unaligned tables under experience Feb 16, 2021
@hossainemruz hossainemruz added the hacktoberfest Mark an issue so that contributor participating hacktoberfest can work on it label Oct 1, 2021
@reyhhan
Copy link
Contributor

reyhhan commented Oct 9, 2021

Hi, does this issue still persist? If it does, I would like to work on this.

@Roxedus Roxedus changed the title Unaligned tables under experience Unaligned tables under education Oct 10, 2021
@Roxedus
Copy link
Contributor Author

Roxedus commented Oct 10, 2021

@hossainemruz
Copy link
Member

@reyhhan Yes. Please, go ahead. I will love to see a PR.

@reyhhan
Copy link
Contributor

reyhhan commented Oct 10, 2021

Thanks!
I just encountered a problem while setting it up. Any idea why I'm seeing this error?
Error: module "toha" not found; either add it as a Hugo Module or store it in "C:\Hugo\Sites\themes\toha\themes".: module does not exist

@hossainemruz
Copy link
Member

Which repo did you cloned? It seems the submodule wasn't cloned properly.

@reyhhan
Copy link
Contributor

reyhhan commented Oct 11, 2021

I just tried out the example site and these are the steps that I followed.

  1. Forked example site repo
  2. Ran the command as explained on README file -> git clone git@github.com:hugo-toha/hugo-toha.github.io.git --recursive

Output :

Cloning into 'hugo-toha.github.io'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@reyhhan
Copy link
Contributor

reyhhan commented Oct 12, 2021

I just tried out the example site and these are the steps that I followed.

  1. Forked example site repo
  2. Ran the command as explained on README file -> git clone git@github.com:hugo-toha/hugo-toha.github.io.git --recursive

Output :

Cloning into 'hugo-toha.github.io'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

Update :

Apparently, my Github account wasn't configured to use SSH and that seems to be the issue.
I tried using the HTTP cloning link instead of SSH and now everything works well! Thanks!

@kodiakhq kodiakhq bot closed this as completed in #434 Oct 12, 2021
kodiakhq bot pushed a commit that referenced this issue Oct 18, 2021
* Fixed alignment issue in tables under education(#233)

* Fixed section landing position on navigation

Co-authored-by: Emruz Hossain <hossainemruz@gmail.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Mark an issue so that contributor participating hacktoberfest can work on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants