Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme with contributing guide and create github templates #110

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Update readme with contributing guide and create github templates #110

merged 1 commit into from
Oct 22, 2020

Conversation

alex-bezek
Copy link
Contributor

@alex-bezek alex-bezek commented Oct 20, 2020 •
edited by hossainemruz

Issue

Fixes #105

Description

  • Adds specific workflow steps to the readme on contributing using a git submodule. I have never worked with them so this was something i had to figure out. might be useful for others
  • Added issue and PR templates linked in the contributing section. These are just useful at work and thought they would be helpful
  • Minor spelling/grammar changes

Test Evidence

@alex-bezek alex-bezek mentioned this pull request Oct 20, 2020
Closed
@hossainemruz hossainemruz added documentation Improvements or additions to documentation enhancement New feature or request and removed documentation Improvements or additions to documentation labels Oct 22, 2020
@hossainemruz hossainemruz self-requested a review October 22, 2020 16:18
hossainemruz
hossainemruz requested changes Oct 22, 2020
View reviewed changes
Copy link
Member

@hossainemruz hossainemruz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! @alex-bezek. Really loving your contribution. Looks good to me.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
hossainemruz
hossainemruz approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@hossainemruz hossainemruz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood the commands. Looks good to me now.

@hossainemruz hossainemruz merged commit 5bc4c2a into hugo-toha:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hossainemruz hossainemruz hossainemruz approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contributing
2 participants
@alex-bezek @hossainemruz