Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing #105

Closed
alex-bezek opened this issue Oct 19, 2020 · 2 comments · Fixed by #110
Closed

Contributing #105

alex-bezek opened this issue Oct 19, 2020 · 2 comments · Fixed by #110

Comments

@alex-bezek
Copy link
Contributor

To start, thank you for the wonderful open source theme. I just ported my blog over to hugo and chose your theme because it was beautiful and easy to work with.

There are some defects I'd like to fix (I opened 1 pr so far here #104 ) and some enhancements around google lighthouse scores I'd like to make if you are open to them (I like for my sites too have as good of scores as possible in performance and accessibility).

I noticed the repo https://github.com/hossainemruz/toha-example-site which it seems you are using for testing updates. You have a basic guide https://github.com/hossainemruz/toha#contributing but I thought it would be useful to document your normal local development lifecycle here as it took me some time to figure out how to work with the git submodule.

On a side note, I think it would be cool if you could add the hacktoberfest topic to the repo for this month
https://hacktoberfest.digitalocean.com/hacktoberfest-update

Again, thank you for all you've done so far. Let me know if you have any guidance around contributing going forward.

@hossainemruz
Copy link
Member

some enhancements around google lighthouse scores I'd like to make if you are open to them (I like for my sites too have as good of scores as possible in performance and accessibility).

Sure. That would be great.

I noticed the repo https://github.com/hossainemruz/toha-example-site which it seems you are using for testing updates. You have a basic guide https://github.com/hossainemruz/toha#contributing but I thought it would be useful to document your normal local development lifecycle here as it took me some time to figure out how to work with the git submodule.

Yes. I feel the need for a development guideline too. Unfortunately, I am not getting some free time to add one. Even the documentations are outdated. It would be great if you can send a PR.

On a side note, I think it would be cool if you could add the hacktoberfest topic to the repo for this month

Done

@alex-bezek
Copy link
Contributor Author

@hossainemruz I opened a PR here #110 with a stab at some documentation. Let me know what you think and if there are more details I should add. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants