Fix issue#24 - Add custom messages for HTTP error pages.

hugopl · May 29, 2015 · a9d14ae · a9d14ae
1 parent f9a5700
commit a9d14ae
Show file tree

Hide file tree

Showing 10 changed files with 35 additions and 204 deletions.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
@@ -5,10 +5,6 @@ class ApplicationController < ActionController::Base
   before_action :authenticate_user!
   before_filter :configure_permitted_parameters, if: :devise_controller?
 
-  rescue_from ActiveRecord::RecordNotFound do |_exception|
-    render file: "#{Rails.root}/public/404", layout: false, status: :not_found
-  end
-
   layout proc { |_controller|
     user_signed_in? ? 'application' : 'devise/sessions'
   }

diff --git a/app/controllers/errors_controller.rb b/app/controllers/errors_controller.rb
@@ -0,0 +1,13 @@
+class ErrorsController < ApplicationController
+
+  def show
+    render status_code.to_s, :status => status_code
+  end
+
+  protected
+
+  def status_code
+    params[:code] || 500
+  end
+
+end
diff --git a/app/views/errors/404.html.erb b/app/views/errors/404.html.erb
@@ -0,0 +1,4 @@
+<div class="alert alert-danger" role="alert">
+  <p style="font-size: 48px;"><strong>404 Not Found</strong></p>
+  <strong>Oops!</strong> The page you requested was not found! <a href="#" onclick="history.back();" class="alert-link">Back to Home</a>.
+<div>
diff --git a/app/views/errors/422.html.erb b/app/views/errors/422.html.erb
@@ -0,0 +1,4 @@
+<div class="alert alert-danger" role="alert">
+  <p styke="font-size: 48px;"><strong>422 Unprocessable Entity (WebDAV; RFC 4918)</strong></p>
+  <strong>Oops!</strong> ... <a href="#" onclick="window.history.back();" class="alert-link">Back to Home</a>.
+<div>
diff --git a/app/views/errors/500.html.erb b/app/views/errors/500.html.erb
@@ -0,0 +1,4 @@
+<div class="alert alert-danger" role="alert">
+  <p style="font-size: 48px;"><strong>500 Internal Server Error</strong></p>
+  <strong>Oops!</strong> An internal error occurred! <a href="#" onclick="history.back();" class="alert-link">Back to Home</a>.
+<div>
diff --git a/config/application.rb b/config/application.rb
@@ -40,5 +40,8 @@ class Application < Rails::Application
 
     # Do not swallow errors in after_commit/after_rollback callbacks.
     config.active_record.raise_in_transactional_callbacks = true
+
+    # Configure the status code templates to be served by the app instead of Rack exception application.
+    config.exceptions_app = self.routes
   end
 end
diff --git a/config/routes.rb b/config/routes.rb
@@ -29,4 +29,11 @@
   get :faq, controller: :application
 
   mount Reviewit::API => '/'
+
+  # Configure each error code to it's respective action on ErrorsController.
+  %w( 404 422 500).each do |code|
+    get code, :to => "errors#show", :code => code
+  end
+
+
 end
diff --git a/public/404.html b/public/404.html
diff --git a/public/422.html b/public/422.html
diff --git a/public/500.html b/public/500.html