Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated camelCase methods #51

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Conversation

hugovk
Copy link
Owner

@hugovk hugovk commented Nov 26, 2021

Remove deprecations from #49. To be released in a major version bump along with #50.

Will unblock #48.

TODO

@hugovk hugovk added the changelog: Removed For now removed features label Nov 26, 2021
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #51 (801238c) into main (48983b5) will decrease coverage by 0.70%.
The diff coverage is 29.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   56.52%   55.81%   -0.71%     
==========================================
  Files           4        4              
  Lines         552      430     -122     
==========================================
- Hits          312      240      -72     
+ Misses        240      190      -50     
Flag Coverage Δ
GHA_Ubuntu 55.81% <29.16%> (-0.71%) ⬇️
GHA_macOS 55.81% <29.16%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/osmviz/animation.py 0.00% <0.00%> (ø)
test/unit/test_manager.py 100.00% <ø> (ø)
src/osmviz/manager.py 81.59% <87.50%> (-2.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48983b5...801238c. Read the comment docs.

@hugovk hugovk force-pushed the rm-deprecated-camelCase-methods branch from e21ebf6 to 801238c Compare November 29, 2021 10:21
@hugovk hugovk merged commit 7843a64 into main Nov 29, 2021
@hugovk hugovk deleted the rm-deprecated-camelCase-methods branch November 29, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Removed For now removed features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant