Fix disable_redirect_output to fix #383 #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We constant disable and reenable logging/redirection. Apparently we are disabling it in the wrong order, which in GDB 8.1 causes issues.
Closed
3 tasks
|
Paging @reijin90 |
|
Sorry for letting you hanging there! The new version does not show the warning anymore, but I still need debug mode as the console size that gef receives seems to be wrong. |
|
Yes, that's another bug, will work on that when I get access to a windows machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We constant disable and reenable logging/redirection. Apparently we are
disabling it in the wrong order, which in GDB 8.1 causes issues.