Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove utf8 encoding declaration #770

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

theguy147
Copy link
Collaborator

refactor: remove utf8 encoding declaration

Description/Motivation/Screenshots

As Part of PEP 3210 in Python 3.0 the utf-8 encoding declaration is the default and can be omitted (which saves some bytes for the whole file ;) )

How Has This Been Tested?

Architecture Yes/No Comments
x86-32 ✔️
x86-64 ✔️
ARM ✖️
AARCH64 ✖️
MIPS ✖️
POWERPC ✖️
SPARC ✖️
RISC-V ✖️
make test ✖️ test_cmd_elf_info already failed on this branch before this PR

Checklist

  • My PR was done against the gdb_8_py36_code_refactor branch, not master.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • My change adds tests as appropriate.
  • I have read and agree to the CONTRIBUTING document.

@hugsy
Copy link
Owner

hugsy commented Dec 14, 2021

FTR this line has nothing to do with Python, it was an Emacs property which I used when I started working on gef. I think Vim recognizes it too. But now it's probably useless with modern IDE.

@hugsy hugsy merged commit 8a27a38 into hugsy:gdb_8_py36_code_refactor Jan 7, 2022
@hugsy hugsy added this to the Release: next milestone Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants