Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bugs in GefSetting that prevented saved values to be loaded #792

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Fixed bugs in GefSetting that prevented saved values to be loaded #792

merged 1 commit into from
Jan 17, 2022

Conversation

hugsy
Copy link
Owner

@hugsy hugsy commented Jan 17, 2022

Description/Motivation/Screenshots

#779 brought in a bug in the classes handling the gef save and gef restore commands that prevented non default values to be stored & loaded.

This PR fixes that bug.

How Has This Been Tested?

Architecture Yes/No Comments
x86-32 ✔️
x86-64 ✔️
ARM ✔️
AARCH64 ✔️
MIPS ✖️
POWERPC ✖️
SPARC ✖️
RISC-V ✖️
make test ✔️

Checklist

  • My PR was done against the dev branch, not master.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • My change adds tests as appropriate.
  • I have read and agree to the CONTRIBUTING document.

@hugsy hugsy added this to the Release: next milestone Jan 17, 2022
@hugsy hugsy merged commit 599db81 into dev Jan 17, 2022
@hugsy hugsy deleted the gef_setting_fixes branch January 17, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grazfather Grazfather Grazfather approved these changes

@daniellimws daniellimws daniellimws approved these changes

@theguy147 theguy147 Awaiting requested review from theguy147

Assignees
No one assigned
Labels
bug regression
Projects
None yet
Milestone
Release: 2022.01
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hugsy @Grazfather @daniellimws