GEF code quality improvement, with support with GDB 8+ and Python3.6+ #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used to make the API simpler and more Pythonic. Also adds memory access (via `gef.memory`) and settings (via `gef.config`)
- creates a `GefHeapManager` class - deprecates many functions to an equivalent more readable - made `GlibcArena` and `GlibcChunk` classes iterable
- Add `gef.session` which includes many runtime info (`.pagesize`, `.canary`, `.constants`, etc.) - Add more docstrings - The GDB command objects are now in the namespace `gef.gdb` - Adjust some gef functions to check result - Make `endian_str`, `gef_pagesize`, `gef_read_canary`, `set_gef_setting` and `get_gef_setting` deprecated APIs
- new context manager for output redirection: `RedirectOutputContext`
* refactor: use dict comprehension (PEP 274) * refactor: use generator expressions (PEP 289) * refactor: use yield from syntax (PEP 380)
…gdb_8_py36_code_refactor
… session using `pi reset()`
theguy147
reviewed
Jan 13, 2022
daniellimws
reviewed
Jan 13, 2022
|
I'll remove all my type hint suggestions from this review as I'm feeling like I'm creating more confusion then helping with them here and go back to the initial plan of making a new PR once this one has been merged to get the type hints finalized. |
|
Good idea @theguy147 (although I already fixed some yesterday). Like I mentioned, I don't see any problem for adding (or fixing) the type hinting gradually. Also this PR is big enough with changes on its own (which need to be reviewed and tested). Please refrain from just commenting for just basic linting changes that can be fixed any time. Not everything has to be done in this PR. |
theguy147
requested changes
Jan 13, 2022
theguy147
requested changes
Jan 13, 2022
theguy147
reviewed
Jan 13, 2022
Grazfather
reviewed
Jan 14, 2022
Grazfather
reviewed
Jan 15, 2022
Grazfather
reviewed
Jan 15, 2022
Grazfather
reviewed
Jan 15, 2022
|
Done my review! |
theguy147
approved these changes
Jan 16, 2022
daniellimws
approved these changes
Jan 16, 2022
Grazfather
approved these changes
Jan 16, 2022
Co-authored-by: theguy147 <37738506+theguy147@users.noreply.github.com> Co-authored-by: Grazfather <grazfather@gmail.com>
Grazfather
force-pushed
the
gdb_8_py36_code_refactor
branch
from
e978144
to
fa28aa2
Compare
Grazfather
force-pushed
the
gdb_8_py36_code_refactor
branch
from
8ccccad
to
e4a77aa
Compare
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description/Motivation/Screenshots
Brace yourselves, this is a damn big PR.
It aims to improve the code quality and readability that are allowed by bumping our minimum version requirement for GDB.
This PR:
gefroot namespace allowing to simplify the session information through sub-namespaces likegef.configgef.heapgef.sessiongef.memorygef.uipathlib.Pathobjectsdocs/api.mdand created a newdocs/api/gef.mdwith the entire API of functions/classes exposed by GEF to facilitate even more 3rd party command developmentgef-extras/osFixes #316
Fixes #536
Fixes #767
How Has This Been Tested?
make testChecklist
devbranch, notmaster.