Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for Open Connectivity Foundation DCPs #49

Merged
merged 1 commit into from
Mar 22, 2022
Merged

add support for Open Connectivity Foundation DCPs #49

merged 1 commit into from
Mar 22, 2022

Conversation

mh-cbon
Copy link
Contributor

@mh-cbon mh-cbon commented Mar 21, 2022

No description provided.

huin
huin requested changes Mar 21, 2022
View reviewed changes
Copy link
Owner

@huin huin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This looks much more focused. It's mostly just small nitty points remaining. Thanks :)

cmd/goupnpdcpgen/metadata.go Outdated Show resolved Hide resolved
cmd/goupnpdcpgen/fileutil.go Outdated Show resolved Hide resolved
cmd/goupnpdcpgen/provider.go Outdated Show resolved Hide resolved
cmd/goupnpdcpgen/metadata.go Outdated Show resolved Hide resolved
cmd/goupnpdcpgen/provider.go Show resolved Hide resolved
cmd/goupnpdcpgen/metadata.go Show resolved Hide resolved
@huin huin merged commit 9af4afc into huin:master Mar 22, 2022
@huin
Copy link
Owner

huin commented Mar 22, 2022

Thanks! Merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huin huin huin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mh-cbon @huin