Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More functions support Context #54

Merged
merged 1 commit into from
Oct 2, 2022
Merged

More functions support Context #54

merged 1 commit into from
Oct 2, 2022

Conversation

hzyitc
Copy link
Contributor

@hzyitc hzyitc commented Oct 1, 2022

So we can interrupt the process.

huin
huin requested changes Oct 2, 2022
View reviewed changes
Copy link
Owner

@huin huin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the one required comment to address.

goupnp.go Show resolved Hide resolved
@huin huin merged commit d8bd5d2 into huin:main Oct 2, 2022
@huin
Copy link
Owner

huin commented Oct 2, 2022

Thanks for the contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huin huin huin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hzyitc @huin