Reduce write system calls, thus fewer TCP packets #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do a bit more copying around in user space before handing off the data to the kernel, so that Before this change, one connect, publish and disconnect was 19 packets. After this change, it is 14 packets. Ethernet/IP/TCP overhead is about 66 bytes. So with this change, we use 73% of the bandwidth as before (14*66/19*66 = 0.73).
|
Thanks! Looks good to me. I trust you've run the unit tests. |
huin
pushed a commit
that referenced
this pull request
Aug 22, 2013
Reduce write system calls, thus fewer TCP packets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do a bit more copying around in user space before handing off
the data to the kernel, so that TCP sends fewer packets.
Before this change, one connect, publish and disconnect
was 19 packets. After this change, it is 14 packets.
Ethernet/IP/TCP overhead is about 66 bytes. So with this
change, we use 73% of the bandwidth as before
(14_66/19_66 = 0.73).